WIP exchangeable value types

example.rb

@@ -0,0 +1,23 @@
+$LOAD_PATH.unshift("./lib")
+
+require 'prometheus/client'
+
+prometheus = Prometheus::Client.registry
+
+counter = Prometheus::Client::Counter.new(:counter, 'Example counter')
+gauge = Prometheus::Client::Gauge.new(:gauge, 'Example gauge')
+histogram = Prometheus::Client::Histogram.new(:histogram, 'Example histogram', [0, 1, 2])
+prometheus.register(counter)
+prometheus.register(gauge)
+prometheus.register(histogram)
+
+http_requests.increment(2)
+gauge.set(3)
+histogram.observe(0.5)
+histogram.observe(0.5)
+histogram.observe(1.5)
+histogram.observe(2)
+
+puts "counter", counter.get
+puts "gauge", gauge.get
+puts "histogram", histogram.get

lib/prometheus/client/counter.rb

@@ -1,6 +1,7 @@
 # encoding: UTF-8
 
 require 'prometheus/client/metric'
+require 'prometheus/client/valuetype'
 
 module Prometheus
   module Client
@@ -14,13 +15,13 @@ def increment(labels = {}, by = 1)
         raise ArgumentError, 'increment must be a non-negative number' if by < 0
 
         label_set = label_set_for(labels)
-        synchronize { @values[label_set] += by }
+        synchronize { @values[label_set].increment(by) }
       end
 
       private
 
       def default
-        0
+        Prometheus::Client::ValueType.new(0)
       end
     end
   end

lib/prometheus/client/gauge.rb

@@ -13,7 +13,7 @@ def type
 
       # Sets the value for the given label set
       def set(labels, value)
-        @values[label_set_for(labels)] = value
+        @values[label_set_for(labels)].set(value)
       end
     end
   end

lib/prometheus/client/histogram.rb

@@ -12,21 +12,22 @@ class Histogram < Metric
       class Value < Hash
         attr_accessor :sum, :total
 
-        def initialize(buckets)
-          @sum = 0.0
-          @total = 0
+        def initialize(name, labelnames, labelvalues, buckets)
+          @sum = ValueType.new(name, name + '_sum', labelnames, labelvalues)
+          # TODO: get rid of total and use +Inf bucket instead.
+          @total = ValueType.new(name, name + '_count', labelnames, labelvalues)
 
           buckets.each do |bucket|
-            self[bucket] = 0
+            self[bucket] = ValueType.new(name, name + '_count', labelnames, labelvalues)
           end
         end
 
         def observe(value)
-          @sum += value
-          @total += 1
+          @sum.increment(value)
+          @total.increment()
 
           each_key do |bucket|
-            self[bucket] += 1 if value <= bucket
+            self[bucket].increment() if value <= bucket
           end
         end
       end
@@ -62,7 +63,8 @@ def observe(labels, value)
       private
 
       def default
-        Value.new(@buckets)
+        # TODO: default function needs to know key of hash info (label names and values)
+        Value.new(@name, @labelnames, @labelvalues, @buckets)
       end
 
       def sorted?(bucket)

lib/prometheus/client/metric.rb

@@ -27,7 +27,7 @@ def initialize(name, docstring, base_labels = {})
       def get(labels = {})
         @validator.valid?(labels)
 
-        @values[labels]
+        @values[labels].get
       end
 
       # Returns all label sets with their values
@@ -42,7 +42,7 @@ def values
       private
 
       def default
-        nil
+        ValueType.new(nil)
       end
 
       def validate_name(name)

lib/prometheus/client/summary.rb

@@ -15,11 +15,11 @@ class Value < Hash
         attr_accessor :sum, :total
 
         def initialize(estimator)
-          @sum = estimator.sum
-          @total = estimator.observations
+          @sum = ValueType.new(estimator.sum)
+          @total = ValueType.new(estimator.observations)
 
           estimator.invariants.each do |invariant|
-            self[invariant.quantile] = estimator.query(invariant.quantile)
+            self[invariant.quantile] = ValueType.new(estimator.query(invariant.quantile))
           end
         end
       end

lib/prometheus/client/valuetype.rb

@@ -0,0 +1,25 @@
+# encoding: UTF-8
+
+module Prometheus
+  module Client
+    class SimpleValue
+      def initialize(value)
+        @value = value
+      end
+
+      def set(value)
+        @value = value
+      end
+
+      def increment(by = 1)
+        @value += by
+      end
+
+      def get()
+        @value
+      end
+    end
+
+    ValueType = SimpleValue
+  end
+end