Refactor the integrations specs

Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
prometheus · Sep 18, 2019 · e41c8b1 · e41c8b1
1 parent 8550da5
commit e41c8b1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 18 deletions.
diff --git a/spec/prometheus/integration_spec.rb b/spec/prometheus/integration_spec.rb
@@ -5,15 +5,7 @@
 require 'prometheus/middleware/collector'
 require 'prometheus/middleware/exporter'
 
-API = Rack::Builder.new do
-  use Rack::Deflater
-  use Prometheus::Middleware::Collector
-  use Prometheus::Middleware::Exporter
-
-  map "/" do
-    run ->(_) { [200, {'Content-Type' => 'text/html'}, ['OK']] }
-  end
-end
+require_relative "../support/api"
 
 describe API do
   include Rack::Test::Methods

diff --git a/spec/prometheus/threaded_integration_spec.rb b/spec/prometheus/threaded_integration_spec.rb
@@ -6,15 +6,7 @@
 require 'prometheus/middleware/exporter'
 require "concurrent"
 
-API = Rack::Builder.new do
-  use Rack::Deflater
-  use Prometheus::Middleware::Collector
-  use Prometheus::Middleware::Exporter
-
-  map "/" do
-    run ->(_) { [200, {'Content-Type' => 'text/html'}, ['OK']] }
-  end
-end
+require_relative "../support/api"
 
 describe API do
   include Rack::Test::Methods
@@ -48,6 +40,7 @@
       t4 = Thread.new do
         latch.wait
         res = get '/metrics'
+
         expect(res.body).not_to be_empty
       end
 

diff --git a/spec/support/api.rb b/spec/support/api.rb
@@ -0,0 +1,13 @@
+require 'rack'
+
+API = Rack::Builder.new do
+  use Rack::Deflater
+  use Prometheus::Middleware::Collector
+  use Prometheus::Middleware::Exporter
+
+  map "/" do
+    run ->(_) { [200, {'Content-Type' => 'text/html'}, ['OK']] }
+  end
+end
+
+