Export per-pid values from gauges by default #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Sinjakli <chris@gocardless.com>
Sinjo
force-pushed
the
sinjo-default-unaggregated-gauges
branch
from
1a4d32e
to
cbecc25
Compare
|
Following a conversation with @dmagliola, I've decided to leave that extra commit off. It's a nice-to-have, it'd be a non-breaking change if we added it in the future, and the current approach isn't particularly onerous. Taking this out of draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
DirectFileStoreto use the:allaggregation mode for gauges by default.I'm considering adding a config option to the store to allow the default to be overridden, for use in cases where people want to provide their own label that distinguishes between processes but changes less often than process IDs do.
I'll try to add a commit early next week for that.
Fixes #107