Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPATIBILITY.md #136

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

lawrencejones
Copy link
Contributor

Create a starting compatibility guide that can help maintainers support
the on-going development of this client.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b6bf163 on lawrencejones:lawrence-compatibility into 3652cf7 on prometheus:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b6bf163 on lawrencejones:lawrence-compatibility into 3652cf7 on prometheus:master.

@coveralls
Copy link

coveralls commented Jun 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 9e31202 on lawrencejones:lawrence-compatibility into 1b23a47 on prometheus:master.

COMPATIBILITY.md Outdated

# Deprecation

Whenever a version of Ruby fails out of support we will mirror that change in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s/fails/falls/ ?
(I may be failing at English. If so, please ignore me)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, falls.

Copy link
Collaborator

@dmagliola dmagliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but generally speaking, 👍
Could you correct that typo / confirm it wasn't a typo, and i'll merge? :)

Create a starting compatibility guide that can help maintainers support
the on-going development of this client.

Signed-off-by: Lawrence Jones <lawrjone@gmail.com>
@lawrencejones
Copy link
Contributor Author

Yep, was typo. This should be good now!

@dmagliola dmagliola merged commit 607a43a into prometheus:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants