readme: remove warning of legacy pushgateway API #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the DCO. I assume the Ruby client is actually not using the legacy API anymore? (If it did, it wouldn't work with recent versions of the PGW.) |
As of 0.9.0 (and in particular #102) Björn has made the warning of the legacy API no longer accurate. Let's update the README too. Signed-off-by: David Worth <dworth@strava.com>
|
Oops, I didn't know about the DCO - sorry about that @beorn7 - should we add that to As for the compatibility note, the client is not thanks to your contribution in the linked PR (102) - we ran into this recently at Strava in an upgrade to our Rails app. |
|
Cool. Forgot about me own heroic deeds. 😆 WRT CONTRIBUTING.md: Other Prometheus projects mention the DCO in their version of the file. I think it would make sense to pull it in here. |
beorn7
approved these changes
Oct 16, 2019
|
Good catch! Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 0.9.0 (and in particular #102) Björn has made the warning of the legacy API no longer accurate. Let's update the README too.