Remove outdated doc from collector middleware #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmagliola
requested changes
Oct 23, 2019
There was a problem hiding this comment.
Thank you for this PR! Good catch, we missed this documentation!
One small request, though... While it is correct that we need to remove all references to Label Builders or changing these labels, I think it's still valuable to keep the bit that documents what labels will come with those metrics.
Could you apply that little diff I proposed and squash into a single commit, and I'll get this merged?
Thank you!
Also describe `:metrics_prefix` option. Signed-off-by: Shouichi Kamiya <shouichi.kamiya@gmail.com> Co-Authored-By: Daniel Magliola <dmagliola@crystalgears.com>
|
Thanks, applied the suggested patch and squashed commits 🚀 |
dmagliola
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also describe
:metrics_prefixoption.PTAL @Sinjo.