add DCO to CONTRIBUTING.md #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmagliola
reviewed
Oct 28, 2019
CONTRIBUTING.md
Outdated
| @@ -10,3 +10,5 @@ Prometheus uses GitHub to manage reviews of pull requests. | |||
| on our [mailing list](https://groups.google.com/forum/?fromgroups#!forum/prometheus-developers). | |||
| This will avoid unnecessary work and surely give you and us a good deal | |||
| of inspiration. | |||
|
|
|||
| * Be sure to sign off on the [DCO](https://github.com/probot/dco#how-it-works) | |||
There was a problem hiding this comment.
Could we say sign your commits off, and have an example of how you'd do it, as a shortcut to not have to go to that document?
I was caught off guard after being asked to sign off on the DCO because it was not in the contribution guide. Adding it here. Signed-off-by: David Worth <fixintheworld@gmail.com>
dmagliola
approved these changes
Oct 28, 2019
|
That's great, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was caught off guard after being asked to sign off on the DCO because
it was not in the contribution guide. Adding it here.