Remove Counter#decrement #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,14 +11,12 @@ def type | |||
| end | |||
|
|
|||
| def increment(labels = {}, by = 1) | |||
| fail ArgumentError, 'increment must be a postive integer' if by < 1 | |||
There was a problem hiding this comment.
It must be non-negative, 0 and 0.5 are both fine.
There was a problem hiding this comment.
Hm. Right, actually it's about floats (damn untyped languaged). I don't see too much sense in increasing by 0, but fair enough given it's the same as not increasing at all.
grobie
force-pushed
the
remove-counter-decrement
branch
from
f8b0e1b
to
ed9adc7
Compare
| @@ -31,6 +31,12 @@ | |||
| end.to change { counter.get }.by(5) | |||
| end | |||
|
|
|||
| it 'raises an ArgumentError on non-positive increments' do | |||
|
👍 There's the odd use case, but it's more for consistency with Summary/Histogram. |
It was decided that counters should always be monotonically increasing, so we have to remove possibilities to decrement a counter. Fixes #16.
grobie
force-pushed
the
remove-counter-decrement
branch
from
ed9adc7
to
91f0202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided that counters should always be monotonically increasing,
so we have to remove possibilities to decrement a counter.
Fixes #16.
@jc @juliusv