Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON exposition format support #18

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Remove JSON exposition format support #18

merged 1 commit into from
Jan 12, 2016

Conversation

grobie
Copy link
Member

@grobie grobie commented Jan 12, 2016

JSON has been deprecated as exposition format long time ago. Time to
remove support from client_ruby.

@brian-brazil @fabxc

@brian-brazil
Copy link

The tests seem to be failing, otherwise 👍

@fabxc
Copy link

fabxc commented Jan 12, 2016

👍 for removing it

On Tue, Jan 12, 2016, 9:42 AM Brian Brazil notifications@github.com wrote:

The tests seem to be failing, otherwise [image: 👍]


Reply to this email directly or view it on GitHub
#18 (comment)
.

@grobie
Copy link
Member Author

grobie commented Jan 12, 2016

@brian-brazil Yeah, unfortunately they broke the rack-test gem compatibility with 1.9.3. I'll see if locking the version is possible. I have a pre-commit hook to run the tests and they pass fine on ruby 2.x.

JSON has been deprecated as exposition format long time ago. Time to
remove support from client_ruby.
@grobie
Copy link
Member Author

grobie commented Jan 12, 2016

Tests are green. Travis issues -.-

grobie added a commit that referenced this pull request Jan 12, 2016
Remove JSON exposition format support
@grobie grobie merged commit 83a7940 into master Jan 12, 2016
@grobie grobie deleted the remove-json-format branch January 12, 2016 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants