Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document implications of negative observations #226

Merged
merged 1 commit into from Jun 1, 2021
Merged

Document implications of negative observations #226

merged 1 commit into from Jun 1, 2021

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented May 26, 2021

Fixes #218.

Signed-off-by: beorn7 beorn@grafana.com

@beorn7
Document implications of negative observations
5c67aa6 
Fixes #218.

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 requested a review from dmagliola May 26, 2021 21:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5c67aa6 on beorn7/doc into f4ce120 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5c67aa6 on beorn7/doc into f4ce120 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5c67aa6 on beorn7/doc into f4ce120 on master.

@beorn7
Copy link
Member Author

beorn7 commented May 31, 2021

Gentle 🛎️ @dmagliola (or @Sinjo ?).

@beorn7 beorn7 requested a review from Sinjo June 1, 2021 14:46
Sinjo
Sinjo approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@Sinjo Sinjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the slow review. Things a little hectic my side right now (changing jobs).

@Sinjo Sinjo merged commit 9c79b94 into master Jun 1, 2021
@Sinjo Sinjo deleted the beorn7/doc branch June 1, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sinjo Sinjo Sinjo approved these changes

@dmagliola dmagliola Awaiting requested review from dmagliola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document implications of negative observations for Summaries and Histograms
3 participants
@beorn7 @coveralls @Sinjo