Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate label names #236

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Validate label names #236

merged 2 commits into from
Jan 9, 2022

Commits on Jan 9, 2022

  1. Fix typo in spec description 

    Looks like a regex replacement was run against this file and was a
little too eager.

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
    @Sinjo
    Sinjo committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    8bdd50d View commit details
    Browse the repository at this point in the history

  2. Validate label names 

    Up to now, we've only been performing limited validation of label names.
This commit validates that the characters use match the regex
`/\A[a-zA-Z_][a-zA-Z0-9_]*\Z/` as specified by:

https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
    @Sinjo
    Sinjo committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    3519342 View commit details
    Browse the repository at this point in the history