Use lowercase response headers in Rack example #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because HTTP/2 requires that headers are sent in lowercase, Rack has started validating that no header contains an uppercase letter. We were setting uppercase headers as that was a common convention in HTTP/1.1, where they were interpreted in a case-insensitive fashion. This change makes us compatible with Rack 3.0 without breaking compatibiility for older versions (not that it would matter for this example code). Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Sinjo
force-pushed
the
sinjo-lowercase-example-headers
branch
from
59b20c9
to
c78dbb0
Compare
|
I think this might come and hit us in our exporter middleware too, but I need to test the compatibility implications of changing that. I'd be shocked if Prometheus weren't treating them in a case-insensitive way, but I'll give it a try before I PR a change in for those. |
dmagliola
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because HTTP/2 requires that headers are sent in lowercase, Rack has started validating that no header contains an uppercase letter.
We were setting uppercase headers as that was a common convention in HTTP/1.1, where they were interpreted in a case-insensitive fashion.
This change makes us compatible with Rack 3.0 without breaking compatibiility for older versions (not that it would matter for this example code).
Fixes #267