Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use histogram for http_request_duration_seconds #28

Closed
wants to merge 1 commit into from

Conversation

tmc
Copy link

@tmc tmc commented Aug 15, 2016

closes #27

@coveralls
Copy link

coveralls commented Aug 15, 2016

Coverage Status

Coverage remained the same at 98.819% when pulling 8785389 on tmc:tmc.histogram into 40091e1 on prometheus:master.

@grobie
Copy link
Member

grobie commented Aug 18, 2016

So the tests would need to get updated, but I was thinking about changing the default metric name according to @brian-brazil's http://www.robustperception.io/on-the-naming-of-things/. Given this will be a breaking change anyway, we could do both things at once.

How awkward is the namespacing? Would it make more sense to move the rack middlewares to something like Prometheus::Rack::Exporter or a more generic Prometheus::Middleware::Exporter?

@grobie
Copy link
Member

grobie commented Sep 9, 2016

Replaced by #32

@grobie grobie closed this Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use histogram in rack collector.
3 participants