Declare base64 gem dependency, ready for Ruby 3.4. #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base64 gem is no longer a default gem in Ruby 3.4. Add base64 to the gemspec, for forward compatibility with Ruby 3.4 and to resolve the `base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0` warning that Ruby 3.3 emits on loading client_ruby. https://docs.ruby-lang.org/en/master/NEWS_md.html#label-Stdlib+updates Signed-off-by: Chris Banks <chris@banks.cx>
Sinjo
approved these changes
May 15, 2024
There was a problem hiding this comment.
Thanks for fixing this!
I'm gonna ignore that JRuby 9.1 build being sad and force the merge through. I don't know exactly what's going on there, but that version currently gets special treatment and I think it's time to say goodbye to it.
|
Thanks @Sinjo! Was just having a look into that test failure myself. |
|
Sorry, scratch that last part, |
|
it adds a new question for those use ruby < 2.4... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base64 gem is no longer a default gem in Ruby 3.4.
Add base64 to the gemspec, for forward compatibility with Ruby 3.4 and to resolve the
base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0warning that Ruby 3.3 emits on loading client_ruby.