feat(encoding): implement EncodeLabelKey and EncodeLabelValue for Arc
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Jan 30, 2024
|
Also please follow up on the DCO CI failure: https://github.com/prometheus/client_rust/pull/188/checks?check_run_id=20974266838 |
|
Updated. I've also added |
mxinden
reviewed
Jan 30, 2024
CHANGELOG.md
Outdated
Comment on lines
9
to
15
| ### Added | ||
|
|
||
| - Added `EncodeLabelValue` and `EncodeLabelKey` implementations for for `Arc`, | ||
| `Rc`, and `Box`. | ||
|
|
||
| [PR 188]: https://github.com/prometheus/client_rust/pull/188 | ||
|
|
There was a problem hiding this comment.
This needs to go into a new [0.22.1] section.
CHANGELOG.md
Outdated
| @@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [0.22.0] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Added `EncodeLabelValue` and `EncodeLabelKey` implementations for for `Arc`, | |||
There was a problem hiding this comment.
Suggested change
| - Added `EncodeLabelValue` and `EncodeLabelKey` implementations for for `Arc`, | |
| - Added `EncodeLabelValue` and `EncodeLabelKey` implementations for `Arc`, |
… `Arc` Signed-off-by: Andre Masella <andre@masella.name>
|
Fixed. |
Signed-off-by: Max Inden <mail@max-inden.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds blanket implementations to encode reference-counted keys and values.