*: Remove AtomicU64 on unsupported platforms #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chitoku <odango@chitoku.jp>
…rted platforms Signed-off-by: Chitoku <odango@chitoku.jp>
chitoku-k
force-pushed
the
drop-atomic64-for-unsupported-platforms
branch
from
4a5b4b3
to
5bfff61
Compare
mxinden
reviewed
Feb 2, 2022
Signed-off-by: Chitoku <chitoku-k@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de>
mxinden
changed the title
mxinden
changed the title
Signed-off-by: Max Inden <mail@max-inden.de>
mxinden
force-pushed
the
drop-atomic64-for-unsupported-platforms
branch
from
a4827bf
to
5460b15
Compare
|
Thanks for the help here. I can do a patch release in the next couple of days, in case that is of some help @chitoku-k?! |
|
Thanks! It would be appreciated if this is going to be released with a patch release in the near future as I am currently working with this using crate patch. |
ackintosh
pushed a commit
to ackintosh/client_rust
that referenced
this pull request
Aug 27, 2022
…s#42) Use `AtomicU32` on platforms that don't support `AtomicU64`. Co-authored-by: Max Inden <mail@max-inden.de> Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #37 in regard to how this crate handles
std::sync::atomic::AtomicU64, this PR removes any occurrences of this struct and instead defaults to its 32-bit version where appropriate.