Add Debug impls and fix clippy warnings #71
Conversation
| @@ -1,6 +1,7 @@ | |||
| #![forbid(unsafe_code)] | |||
| #![deny(unused)] | |||
| #![deny(dead_code)] | |||
| #![warn(missing_debug_implementations)] | |||
There was a problem hiding this comment.
I am a bit undecided. I don't think we should be adding Debug implementations to types by default as it slows compile time and bloats the compiled binary.
Do you feel strongly about this? What do you think of removing this line but keeping the new derive statements below?
| #![warn(missing_debug_implementations)] |
There was a problem hiding this comment.
This only lints for public types I believe. So it's not every type.
But I don't feel super strongly about it. Though I think it is a good idea.
Your call :)
There was a problem hiding this comment.
This only lints for public types I believe. So it's not every type.
Good point. Thanks. Let's keep it as is then.
Victor-N-Suadicani
force-pushed
the
debug_impls
branch
from
9b0c967
to
0eb6318
Compare
| @@ -1,6 +1,7 @@ | |||
| #![forbid(unsafe_code)] | |||
| #![deny(unused)] | |||
| #![deny(dead_code)] | |||
| #![warn(missing_debug_implementations)] | |||
There was a problem hiding this comment.
This only lints for public types I believe. So it's not every type.
Good point. Thanks. Let's keep it as is then.
Victor-N-Suadicani
force-pushed
the
debug_impls
branch
from
d943be3
to
da0f1b5
Compare
Signed-off-by: Victor Nordam Suadicani <v.n.suadicani@gmail.com>
Signed-off-by: Victor Nordam Suadicani <v.n.suadicani@gmail.com>
Signed-off-by: Victor Nordam Suadicani <v.n.suadicani@gmail.com>
Victor-N-Suadicani
force-pushed
the
debug_impls
branch
from
da0f1b5
to
12b6fff
Compare
Signed-off-by: Victor Nordam Suadicani <v.n.suadicani@gmail.com> Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
Lots of public types are missing
Debugimpls. I've added most of the easy Debug impls and also added#![warn(missing_debug_implementations)]to the top level.There are also quite a few Clippy warnings that have been fixed.