Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive-encode: Fix multiple applicable items in scope error #93

Merged
merged 3 commits into from Sep 21, 2022
Merged

derive-encode: Fix multiple applicable items in scope error #93

merged 3 commits into from Sep 21, 2022

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Sep 17, 2022 •
edited

multiple applicable items in scope error happens when there is an encode implementation (e.g. prost::Message) in the same scope.

        // error[E0034]: multiple applicable items in scope
        //     |
        // 120 |         #[derive(Clone, Hash, PartialEq, Eq, Encode)]
        //     |                                              ^^^^^^ multiple `encode` found

@ackintosh
Add a test case to reproduce multiple applicable items in scope error
73d931a 
Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
@ackintosh
Copy link
Contributor Author

Okay, the unit test has failed as expected.

https://github.com/prometheus/client_rust/actions/runs/3072132821/jobs/4963408836

@ackintosh
Fix multiple applicable items in scope error
5621ec6 
Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
@ackintosh
Remove needless test case which has no assertions
5e145bb 
Signed-off-by: ackintosh <sora.akatsuki@gmail.com>
@ackintosh
Copy link
Contributor Author

ackintosh commented Sep 17, 2022 •
edited

@mxinden I think a change log entry for this PR is not needed as v0.19 (protobuf feature) is not released. Let me know if it's needed. 🙂

@ackintosh ackintosh marked this pull request as ready for review September 17, 2022 05:19
mxinden
mxinden approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix. No changelog entry needed.

Sorry for the delay on releasing this.

@mxinden mxinden merged commit 12c1de5 into prometheus:master Sep 21, 2022
@ackintosh ackintosh mentioned this pull request Sep 28, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ackintosh @mxinden