add health/ready endpoints #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhungus
force-pushed
the
add_health_and_ready_endpoints
branch
2 times, most recently
from
83d98a2
to
585f43e
Compare
Signed-off-by: Izaak Alpert (karlhungus) <ialpert@salesforce.com>
|
|
||
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { | ||
| resp.setContentType("text/html"); | ||
| resp.getWriter().print("OK"); |
There was a problem hiding this comment.
This isn't valid HTML.
There was a problem hiding this comment.
Fair, i took inspiration from the prometheus health endpoint, which I don't believe is valid html either... would:
<html>ok</html>be sufficient?
There was a problem hiding this comment.
Switching to text/plain is simplest.
There was a problem hiding this comment.
I guess to be html valid it'd have to be:
<!doctype html>
<html lang=en>
<head>
<meta charset=utf-8>
<title>cloudwatch exporter</title>
</head>
<body>ok
</body>
</html>There was a problem hiding this comment.
Thanks, i'm not a smart man :)
karlhungus
force-pushed
the
add_health_and_ready_endpoints
branch
from
6ba6c6a
to
46bb237
Compare
Signed-off-by: Izaak Alpert (karlhungus) <ialpert@salesforce.com>
Signed-off-by: Izaak Alpert (karlhungus) <ialpert@salesforce.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I wanted to have a k8s pod for running my cloud watch exporter, but no readiness/health endpoint exists
Solution
Add one. These seem a little bit silly (they both just respond if the server is running, and don't say anything about the status of the connection to AWS (I took inspiration from prometheus: https://github.com/prometheus/prometheus/blob/2bd510a63e48ac6bf4971d62199bdb1045c93f1a/web/web.go#L297-L304)
This also addresses: #32, which was closed but... @brian-brazil