Added automatic code formatter #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or-shachar
force-pushed
the
or-shachar/lint-spotify
branch
4 times, most recently
from
01d007d
to
389d161
Compare
or-shachar
force-pushed
the
or-shachar/lint-spotify
branch
from
2785d32
to
249d111
Compare
|
I like it! I think JDK 11 is totally fine, we don't test on anything but 17 anyway, and since this isn't a library I am not worried about broad legacy support. |
matthiasr
approved these changes
Apr 28, 2022
|
#417 is merged, could you rebase this PR so we can get it merged, or allow me to make modifications? |
Signed-off-by: or-shachar <or.shachar@wiz.io>
or-shachar
force-pushed
the
or-shachar/lint-spotify
branch
from
cf3bd40
to
965235b
Compare
Signed-off-by: or-shachar <or.shachar@wiz.io>
or-shachar
force-pushed
the
or-shachar/lint-spotify
branch
from
965235b
to
af70e35
Compare
Signed-off-by: or-shachar <or.shachar@wiz.io>
|
@matthiasr - I think we're ready here too 🌷 |
|
Beautiful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #417 :-)
Note: this requires JDK > 11
The first commit is adding a maven plugin that can check and auto-fix formatting + adds CircleCI step that fails if somehow the developer forgot to format. You can see the CircleCI failure (as the code is not formatted).
The second commit is after applying the plugin format.