Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maven dependencies (jetty 10->11) #421

Merged
merged 2 commits into from
May 11, 2022
Merged

Update maven dependencies (jetty 10->11) #421

merged 2 commits into from
May 11, 2022

Conversation

or-shachar
Copy link
Contributor

@or-shachar or-shachar commented May 7, 2022 •
edited

Fixes #390 ... +

  1. Moving repeated versions to maven properties (aws, prometheus)
  2. Updating prometheus - 0.14.1 --> 0.15.0
  3. Updating jetty - 10.0.8 --> 11.0.9
  4. commons-coden 1.13 --> 1.15
  5. Updating maven compiler plugin and release level.
  6. Updated CircleCI image to cimg/openjdk:17.0.3 (instead of deprecated openjdk image)

@or-shachar
Update maven dependencies (jetty 10->11)
91ce138 
Signed-off-by: or-shachar <or.shachar@wiz.io>
@or-shachar or-shachar mentioned this pull request May 8, 2022
Merged
3 tasks
SuperQ
SuperQ reviewed May 9, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
SuperQ
SuperQ reviewed May 9, 2022
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks mostly good. Just want to change the version pinning to be less strict.

@or-shachar
Copy link
Contributor Author

Thanks for the CR @SuperQ ! 🙏

@or-shachar
Updated CircleCI image
8ed934f 
Signed-off-by: or-shachar <or.shachar@wiz.io>
@SuperQ SuperQ requested a review from matthiasr May 10, 2022 06:27
matthiasr
matthiasr approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@matthiasr matthiasr merged commit b0ad175 into prometheus:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasr matthiasr matthiasr approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Jetty 11
3 participants
@or-shachar @matthiasr @SuperQ