Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed null unit in HELP in case of GetMetricStatistics #423

Merged
merged 1 commit into from
May 15, 2022
Merged

Fixed null unit in HELP in case of GetMetricStatistics #423

merged 1 commit into from
May 15, 2022

Conversation

or-shachar
Copy link
Contributor

Partially fixes #422

@or-shachar
Fixed null unit in HELP in case of GetMetricStatistics
b6ff4d7 
Signed-off-by: or-shachar <or.shachar@wiz.io>
@SuperQ SuperQ requested a review from matthiasr May 9, 2022 13:38
SuperQ
SuperQ approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiasr
Copy link
Contributor

Thank you!

@matthiasr matthiasr merged commit 4728b7a into prometheus:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@matthiasr matthiasr Awaiting requested review from matthiasr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Unit" is missing from HELP after #414
3 participants
@or-shachar @matthiasr @SuperQ