Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GetMetricData] Fixed compiler warnings + README permission note #424

Merged
merged 1 commit into from
May 15, 2022

Conversation

or-shachar
Copy link
Contributor

Fixing compiler warnings + spelling on GetMetricDataDataGetter.java + added note about new permission requirements to the README

Signed-off-by: or-shachar <or.shachar@wiz.io>
@or-shachar or-shachar force-pushed the fixed-GetMetricDataWarnings branch from c96affd to cf8fe6b Compare May 12, 2022 06:23
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the docs. I ran into that when trying out the new feature. ^.^

@SuperQ SuperQ requested a review from matthiasr May 12, 2022 11:09
@matthiasr
Copy link
Contributor

Awesome thank you!

@matthiasr matthiasr merged commit 237249f into prometheus:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants