list-metrics-warnings made configurable #447
Conversation
or-shachar
force-pushed
the
configurable-list-metrics-warn
branch
from
c456b3e
to
08b5d5e
Compare
There was a problem hiding this comment.
I am not entirely sure about the description of the two "modes" – this seems like an implementation leaking through into the description of the user experience.
I am wondering if it would be easier to follow if we describe the default behavior (minimum necessary configuration, and what happens with that), and then wuat changes when you set one of the other options?
|
Thanks for the feedback... Indeed I had a hard time describing the list-dimension process. My intent was that users would have an easier time troubleshooting "missing metrics" problems (maybe a better user-centric idea is to add a troubleshooting section). I wonder if I should split the README change and the configurable warning change to separate PR. WDYT? |
|
Yes that's a good idea, then we can get the option out sooner |
or-shachar
force-pushed
the
configurable-list-metrics-warn
branch
from
08b5d5e
to
92b7def
Compare
Signed-off-by: or-shachar <or.shachar@wiz.io>
or-shachar
force-pushed
the
configurable-list-metrics-warn
branch
from
c89b19c
to
f2996e8
Compare
|
Hey @matthiasr sorry it took me so long to pick it up again. |
|
Awesome, thank you for finishing it up! |
Addresses #442
(still WIP) Added explanation in README on how exporter determines which dimensions to scrape.(will create a different PR)