Skip to content

enable more linters #483

enable more linters

enable more linters #483

Triggered via pull request May 12, 2023 12:49
@mmorel-35mmorel-35
synchronize #473
linters
Status Failure
Total duration 32s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 8 warnings
lint: config/http_config.go#L1107
unslice: could simplify caHash[:] to caHash (gocritic)
lint: config/http_config.go#L1108
unslice: could simplify certHash[:] to certHash (gocritic)
lint: config/http_config.go#L1109
unslice: could simplify keyHash[:] to keyHash (gocritic)
lint: config/http_config.go#L1132
unslice: could simplify caHash[:] to caHash (gocritic)
lint: config/http_config.go#L1133
unslice: could simplify certHash[:] to certHash (gocritic)
lint: config/http_config.go#L1134
unslice: could simplify keyHash[:] to keyHash (gocritic)
lint: config/http_config_test.go#L344
ifElseChain: rewrite if-else to switch statement (gocritic)
lint: config/http_config_test.go#L876
unnecessary conversion (unconvert)
lint: config/http_config_test.go#L902
unnecessary conversion (unconvert)
lint: config/http_config_test.go#L928
unnecessary conversion (unconvert)
lint
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/setup-go@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
lint: config/http_config.go#L254
receiver-naming: receiver name a should be consistent with previous receiver name o for OAuth2 (revive)
lint: expfmt/expfmt.go#L27
var-naming: don't use underscores in Go names; const OpenMetricsVersion_0_0_1 should be OpenMetricsVersion0_0_1 (revive)
lint: expfmt/expfmt.go#L28
var-naming: don't use underscores in Go names; const OpenMetricsVersion_1_0_0 should be OpenMetricsVersion1_0_0 (revive)
lint: expfmt/expfmt.go#L36
var-naming: don't use underscores in Go names; const FmtOpenMetrics_1_0_0 should be FmtOpenMetrics1_0_0 (revive)
lint: expfmt/expfmt.go#L37
var-naming: don't use underscores in Go names; const FmtOpenMetrics_0_0_1 should be FmtOpenMetrics0_0_1 (revive)
lint: promlog/log.go#L134
unexported-return: exported func NewDynamic returns unexported type *promlog.logger, which can be annoying to use (revive)
lint: promlog/log.go#L145
unexported-return: exported func NewDynamicWithLogger returns unexported type *promlog.logger, which can be annoying to use (revive)