Code review feedback

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
prometheus · Mar 5, 2021 · 745afa4 · 745afa4
1 parent 2a23014
commit 745afa4
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/model/time.go b/model/time.go
@@ -262,13 +262,16 @@ func (d Duration) MarshalJSON() ([]byte, error) {
 
 // UnmarshalJSON implements the json.Unmarshaler interface.
 func (d *Duration) UnmarshalJSON(bytes []byte) error {
-	var err error
 	var s string
 	if err := json.Unmarshal(bytes, &s); err != nil {
 		return err
 	}
-	*d, err = ParseDuration(s)
-	return err
+	dur, err := ParseDuration(s)
+	if err != nil {
+		return err
+	}
+	*d = dur
+	return nil
 }
 
 // MarshalText implements the encoding.TextMarshaler interface.