Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expfmt: Don't panic on decoding corrupt data #72

Closed
beorn7 opened this issue Jan 5, 2017 · 0 comments · Fixed by #73
Closed

expfmt: Don't panic on decoding corrupt data #72

beorn7 opened this issue Jan 5, 2017 · 0 comments · Fixed by #73
Assignees
@beorn7
Labels
bug

Comments

@beorn7
Copy link
Member

beorn7 commented Jan 5, 2017

https://github.com/prometheus/common/blob/master/expfmt/decode.go#L182 panics upon an unknown metric family type. This can be triggered by corrupt input data. We should return an error instead to not crash e.g. the whole Prometheus server during ingesting metrics with corrupted data.
@beorn7 beorn7 added the bug label Jan 5, 2017
@beorn7 beorn7 self-assigned this Jan 5, 2017
@beorn7 beorn7 mentioned this issue Jan 5, 2017
Closed
beorn7 pushed a commit that referenced this issue Jan 8, 2017
expfmt: Don't panic on decoding corrupt data
473806e 
This requires callers of `ExtractSamples` to be updated.

Fixes #72
@beorn7 beorn7 mentioned this issue Jan 8, 2017
Merged
beorn7 pushed a commit that referenced this issue Jan 8, 2017
expfmt: Don't panic on decoding corrupt data
cba9591 
This requires callers of `ExtractSamples` to be updated.

Fixes #72
@beorn7 beorn7 closed this as completed in #73 Jan 8, 2017
beorn7 pushed a commit to prometheus/prometheus that referenced this issue Jan 9, 2017
vendoring: Update prometheus/common to pull in bug fixes
86ec87b 
In particular the one for prometheus/common#72.
@beorn7 beorn7 mentioned this issue Jan 9, 2017
Merged
gouthamve pushed a commit to gouthamve/common that referenced this issue Jul 22, 2018
@juliusv @jml
Allow nil histograms in instrumentation (prometheus#72)
a13a54f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beorn7 beorn7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expfmt: Don't panic on decoding corrupt data prometheus/common
1 participant
@beorn7