Add charset to text/plain Content-Type #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobie
approved these changes
Feb 28, 2018
expfmt/expfmt.go
Outdated
| @@ -26,7 +26,7 @@ const ( | |||
|
|
|||
| // The Content-Type values for the different wire protocols. | |||
| FmtUnknown Format = `<unknown>` | |||
| FmtText Format = `text/plain; version=` + TextVersion | |||
| FmtText Format = `text/plain; charset=utf-8; version=` + TextVersion | |||
There was a problem hiding this comment.
We put it at the end usually: https://github.com/prometheus/client_python/blob/master/prometheus_client/exposition.py#L28
|
@brian-brazil I thought about that but couldn’t find definitive proof either way that was “legal” or not. I’ll change it to your suggestion momentarily. |
|
I believe it's valid both ways offhand, but may aswell keep things consistent in case someone is doing over-simplistic handling of the header. |
|
LGTM |
|
Thanks! |
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
twitchyliquid64
added a commit
to tailscale/tailscale
that referenced
this pull request
Feb 9, 2024
Appears to be safe based on: prometheus/common#119 Signed-off-by: Tom DNetto <tom@tailscale.com> Updates: corp#17075
twitchyliquid64
added a commit
to tailscale/tailscale
that referenced
this pull request
Feb 20, 2024
Appears to be safe based on: prometheus/common#119 Signed-off-by: Tom DNetto <tom@tailscale.com> Updates: corp#17075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes encoding issues when viewing
/metricsdirectly.See also prometheus/docs#557, prometheus/prometheus#1988