.circleci: Add config to test against go1.18 #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it was too soon 😅 |
|
you have won the right to fix it :) |
kakkoyun
force-pushed
the
test_go118
branch
3 times, most recently
from
2c8e26a
to
741c7ba
Compare
It wasn't that it was soon (I thought necessary images were not released yet). It was a circleci issue. We needed to upgrade orb config for new convenient images https://circleci.com/developer/images/image/cimg/go |
|
Now 1.18 tests are failing because of #361 I'll look into it. |
Merged
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Change convinient image base Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
|
Superseded by #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com