Allow config file splitting, update test cases #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwplotka This is what I meant in #46 (comment) |
Sorry, this is in one commit because I didn't do a separate update of test cases in the old, non-split config file. You can now pass -config-file multiple times, leading for the mentioned files to be concatenated before YAML parsing happens. Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
force-pushed
the
config-splitting
branch
from
601e051
to
80c9e24
Compare
bwplotka
reviewed
Oct 15, 2021
|
@bwplotka Yup explicitness vs. flexibility, good question. The reference API target config is the same across all my current configs as well, so theoretically that's also one that could be factored out into its own file without any code changes then... but I would feel ok either way, I'll do what you prefer :) |
|
Will merge this for now, feel free to rebase yours on top of it and potentially change the config handling again to your liking :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, this is in one commit because I didn't do a separate update of test
cases in the old, non-split config file.
You can now pass -config-file multiple times, leading for the mentioned
files to be concatenated before YAML parsing happens.
Signed-off-by: Julius Volz julius.volz@gmail.com