Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go #206

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Update Go #206

merged 1 commit into from
Apr 1, 2024

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Mar 1, 2024 •
edited

  • Update Go to 1.22.
  • Update Go modules.
  • Update tests for cipher suites removed in Go 1.22.

@SuperQ SuperQ force-pushed the superq/common_bump branch 2 times, most recently from af9e5df to 7aa1bab Compare March 18, 2024 17:06
@SuperQ
Copy link
Member Author

SuperQ commented Mar 18, 2024

@roidelapluie if you have a chance to look. It seems like Go has disabled some more TLS options. Should I just remove the broken tests?

ArthurSens
ArthurSens reviewed Mar 24, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@SuperQ
Update Go
32efdb9 
* Update Go to 1.22.
* Update Go modules.
* Update tests for cipher suites removed in Go 1.22.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from ArthurSens March 24, 2024 07:33
ArthurSens
ArthurSens approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the TLS changes, but giving the approval in case you just want the rubber stamp :)

@SuperQ SuperQ merged commit 76680a4 into master Apr 1, 2024
7 checks passed
@SuperQ SuperQ deleted the superq/common_bump branch April 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

@roidelapluie roidelapluie Awaiting requested review from roidelapluie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperQ @ArthurSens