switch logging to go-kit #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 2, 2019 23:20
Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
brian-brazil
reviewed
Oct 3, 2019
main.go
Outdated
| parts := strings.Split(line, " ") | ||
| if len(parts) != 3 { | ||
| log.Infof("Invalid part count of %d in line: %s", len(parts), line) | ||
| level.Info(c.logger).Log("msg", "Invalid part count", "length", len(parts), "line", line) |
There was a problem hiding this comment.
parts may be a better key here
main.go
Outdated
|
|
||
| prometheus.MustRegister(sampleExpiryMetric) | ||
| sampleExpiryMetric.Set(sampleExpiry.Seconds()) | ||
|
|
||
| log.Infoln("Starting graphite_exporter", version.Info()) | ||
| log.Infoln("Build context", version.BuildContext()) | ||
| level.Info(logger).Log("msg", "Starting graphite_exporter", "version_info", version.Info(), "version_build_context", version.BuildContext()) |
There was a problem hiding this comment.
We usually do this as two lines
Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
matthiasr
requested changes
Oct 4, 2019
|
Looks good otherwise! |
Co-Authored-By: Matthias Rampke <mr@soundcloud.com> Signed-off-by: pohzipohzi <poh.zihow@gmail.com>
matthiasr
approved these changes
Oct 7, 2019
|
Thank you! |
matthiasr
pushed a commit
that referenced
this pull request
Oct 7, 2019
this warrants a minor version bump
matthiasr
pushed a commit
that referenced
this pull request
Oct 7, 2019
vaehx
pushed a commit
to prosenkranz/graphite_exporter
that referenced
this pull request
Mar 23, 2020
* master: (23 commits) Cut release 0.7.0 makefile: update Makefile.common with newer version Release 0.7.0-rc2 Force Cache Init Release 0.7.0-rc1 Updated dependencies - Updated client golang dependency. - Updated statsd mapper dependency. - Migrated current code to new statsd mapper library. Update main.go Fixed typo Fixed bad label value substitution Added more examples on how to use regex in names Fixed panic on bad runtime flags. Update changelog for prometheus#109 (prometheus#111) Update main.go fix comments run go mod vendor with go 1.13 run go mod vendor fix invalid key switch logging to go-kit Fix go.mod and vendor/ *: bump Go version to 1.13 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #108