Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Switch logging to go-kit #170

Closed
brian-brazil opened this issue Sep 23, 2019 · 5 comments · Fixed by #171
Closed

Switch logging to go-kit #170

brian-brazil opened this issue Sep 23, 2019 · 5 comments · Fixed by #171
Labels
enhancement good first issue

Comments

@brian-brazil
Copy link
Contributor

About two years ago we decided to move from logrus to go-kit for logging, this is one of the repos that still needs switching. prometheus/snmp_exporter#447 is an example PR.
@bharaththiruveedula-zz
Copy link

Can I take it up?

@brian-brazil
Copy link
Contributor Author

We've in Hacktoberfest, maybe leave one or two for other people.

@bharaththiruveedula-zz
Copy link

sure @brian-brazil

@willmadison
Copy link

I'd love to work on this. If no one else is already staking claim to it.

@brian-brazil
Copy link
Contributor Author

Go ahead.

willmadison pushed a commit to willmadison/haproxy_exporter that referenced this issue Oct 1, 2019
prometheus#170 Switches from prometheus common log to go-kit logging
2ea2e51
@Infra-Red Infra-Red mentioned this issue Oct 3, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch logging to go-kit Infra-Red/haproxy_exporter
3 participants
@bharaththiruveedula-zz @willmadison @brian-brazil