Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accepting_conns metric #137

Merged
merged 1 commit into from
Feb 13, 2023
Merged

add accepting_conns metric #137

merged 1 commit into from
Feb 13, 2023

Conversation

beliys
Copy link

@beliys beliys commented Jul 15, 2022

No description provided.

Signed-off-by: Beliy <beliy@syneforge.com>
@beliys
Copy link
Author

beliys commented Jul 15, 2022

@grobie

@matthiasr
Copy link
Contributor

memcached is a bit inconsistent with shortened vs full terms (accepting_conns vs. curr_connections vs. connection_structures). So far we have expanded them in metrics (memcached_current_connections), so I would prefer if we could make this one accepting_connections as well.

Since this PR has been hanging for a bit, I don't want to delay further - I'm going to make the change post-merge.

@matthiasr matthiasr merged commit c9ea298 into prometheus:master Feb 13, 2023
matthiasr added a commit that referenced this pull request Feb 13, 2023
Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants