node-mixin: fix configuration for unset fsSelector/diskDeviceSelector and dashboard query #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
As per prometheus#1429 (comment) we want to fetch all devices and all fs types. Currently, this is done by setting empty string which breaks most queries which rely on it. This fixes it by setting the appropriate selector instead of empty string. Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
s-urbaniak
force-pushed
the
fix-selectors
branch
from
1e9efd1
to
f4417b2
Compare
|
cc @metalmatze |
beorn7
approved these changes
Sep 12, 2019
metalmatze
approved these changes
Sep 12, 2019
|
Thank you @beorn7 and @metalmatze for approving so fast!!! 🙇♂️ |
|
Approving fast, but also forgetting that you cannot merge this on your own… sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1429 (comment)
we want to fetch all devices and all fs types.
Currently, this is done by setting empty string which breaks most queries which rely on it.
This fixes it by setting the appropriate selector instead of empty string.
Additionally this fixes the query in Disk Space Utilisation dashboard.