New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention copr yum repository, add systemd unit #529
Conversation
@@ -0,0 +1 @@ | |||
OPTIONS="-collector.textfile.directory /var/lib/node_exporter/textfile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/var/lib/node_exporter/textfile_collector/
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to vary based on the system and distro, which is why it's very difficult to provide example files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, anything there will be OK for LSB, so it's up to you. Do you prefer textfile_collector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/var/lib/node_exporter/textfile_collector is what my debs use, @TheTincho's Debian debs use a different path. No matter what you put in here, it's going to break for someone.
The last commit renames the textfile directory according to @brian-brazil's preference. I can --of course-- rebase it into one commit. I am not sure about your (prometheus') preferences regarding commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good, thanks! We might want to add a few words about the debian/ubuntu packages too. |
Oh yes, please do!
|
* add systemd unit as example * mention community yum repo fixes prometheus#498 * rename textfile collector dir
fixes #498.