Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention copr yum repository, add systemd unit #529

Merged
merged 3 commits into from Apr 19, 2017

Conversation

ibotty
Copy link
Contributor

@ibotty ibotty commented Mar 22, 2017

fixes #498.

@it-praktyk
Copy link

I didn't test packages provided by @ibotty for CentOS 7 and Fedora yet but I'm generally OK with adding that examples. Thank you @ibotty.

@@ -0,0 +1 @@
OPTIONS="-collector.textfile.directory /var/lib/node_exporter/textfile"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/lib/node_exporter/textfile_collector/
maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to vary based on the system and distro, which is why it's very difficult to provide example files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, anything there will be OK for LSB, so it's up to you. Do you prefer textfile_collector?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/lib/node_exporter/textfile_collector is what my debs use, @TheTincho's Debian debs use a different path. No matter what you put in here, it's going to break for someone.

@ibotty
Copy link
Contributor Author

ibotty commented Mar 22, 2017

The last commit renames the textfile directory according to @brian-brazil's preference. I can --of course-- rebase it into one commit. I am not sure about your (prometheus') preferences regarding commits.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordianfish
Copy link
Member

Looks good, thanks! We might want to add a few words about the debian/ubuntu packages too.

@discordianfish discordianfish merged commit 2a38b57 into prometheus:master Apr 19, 2017
@ibotty
Copy link
Contributor Author

ibotty commented Apr 19, 2017 via email

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* add systemd unit as example

* mention community yum repo

fixes prometheus#498

* rename textfile collector dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide packages and repository for CentOS/RHEL
6 participants