Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netbsd/arm support for now #551

Merged
merged 1 commit into from Apr 11, 2017
Merged

Conversation

grobie
Copy link
Member

@grobie grobie commented Apr 11, 2017

There are crossbuild errors on netbsd/arm with go1.8. Assuming there is
only a small minority of people running netbsd on ARM processors,
disabling these builds is the fastest workaround.

@derekmarcotte @sdurrheimer

There are crossbuild errors on netbsd/arm with go1.8. Assuming there is
only a small minority of people running netbsd on ARM processors,
disabling these builds is the fastest workaround.
@grobie grobie requested a review from sdurrheimer April 11, 2017 15:18
@discordianfish
Copy link
Member

Hrm platform isn't uncommon.. But I guess it's okay to merge this for now, but we need to revive that before the next release.

@grobie
Copy link
Member Author

grobie commented Apr 11, 2017

See the mailing list thread on prometheus-developers@. Given the amount of os/arch combinations we already disabled due to crossbuild issues, I guess we'll need to invest time in a (VM based?) native build fleet. At the moment we either have broken builds or no netbsd/arm.

@grobie
Copy link
Member Author

grobie commented Apr 11, 2017

@SuperQ Cool with you? This will allow us to merge all the outstanding PRs for now.

@discordianfish
Copy link
Member

Couldn't even get the amd64 binaries to run before: #402

@grobie grobie merged commit 09727a6 into master Apr 11, 2017
@grobie grobie deleted the grobie/remove-netbsd-arm-support branch April 11, 2017 15:42
@SuperQ
Copy link
Member

SuperQ commented Apr 11, 2017

LGTM, I'd like to keep the auto-builds moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants