Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make metrics better follow guidelines #787

Merged
merged 9 commits into from
Jan 17, 2018
Merged

Make metrics better follow guidelines #787

merged 9 commits into from
Jan 17, 2018

Commits on Jan 15, 2018

  1. Improve stat linux metric names. 

    cpu is no longer used.
    @brian-brazil
    brian-brazil committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    8621c0c View commit details
    Browse the repository at this point in the history

  2. node_cpu -> node_cpu_seconds_total for Linux

    @brian-brazil
    brian-brazil committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    522776d View commit details
    Browse the repository at this point in the history

  3. Improve filesystem metric names with units

    @brian-brazil
    brian-brazil committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    e3cf6d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Improve units and names of linux disk stats 

    Remove sector metrics, the bytes metrics cover those already.
    @brian-brazil
    brian-brazil committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    9d84c8f View commit details
    Browse the repository at this point in the history

  2. Infiniband counters should end in _total

    @brian-brazil
    brian-brazil committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    679f4e6 View commit details
    Browse the repository at this point in the history

  3. Improve timex metric names, convert to more normal units. 

    See
https://github.com/torvalds/linux/blob/3c073991eb417b6f785ddc6afbbdc369eb84aa6a/kernel/time/ntp.c#L909
for what stabil means, looks like a moving average of some form.
    @brian-brazil
    brian-brazil committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    6bc147f View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. For meminfo metrics that had "kB" units, add _bytes

    @brian-brazil
    brian-brazil committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    6ec36cb View commit details
    Browse the repository at this point in the history

  2. Interrupts counter should have _total

    @brian-brazil
    brian-brazil committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    0199c40 View commit details
    Browse the repository at this point in the history

  3. Update test fixture

    @brian-brazil
    brian-brazil committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    9dfb5d1 View commit details
    Browse the repository at this point in the history