Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian packging warns source-contains-unsafe-symlink #29

Closed
sinzui opened this issue Aug 30, 2016 · 4 comments
Closed

debian packging warns source-contains-unsafe-symlink #29

sinzui opened this issue Aug 30, 2016 · 4 comments

Comments

@sinzui
Copy link

sinzui commented Aug 30, 2016

A run of
lintian -I --pedantic
across the package reveals
E: juju-core source: source-contains-unsafe-symlink src/github.com/prometheus/procfs/fixtures/26231/exe

Anyone packaging this project needs to delete the fixtures directory, but then the tests cannot be run.

@grobie
Copy link
Member

grobie commented Aug 31, 2016

We could create the file on-the-fly, maybe during make test. I guess it'd make more sense to remove the test data from debian packages though.

@sinzui
Copy link
Author

sinzui commented Aug 31, 2016

We did remove the fixtures directory from the source to make the package acceptable for Ubuntu. Now it isn't possible to run the tests. the ideal solution is for the test suite to create the symlink as needed.

@NightTsarina
Copy link

@sinzui, actually, that file is correct there, and you need to add a lintian override.

having said that, there is no need to package this for ubuntu, it is been in debian for quite some time: https://packages.qa.debian.org/g/golang-procfs.html

@grobie
Copy link
Member

grobie commented Sep 1, 2016

Thanks @TheTincho. Closing this as I trust you in all questions around Debian packages.

@grobie grobie closed this as completed Sep 1, 2016
bobrik pushed a commit to bobrik/procfs that referenced this issue Jan 14, 2023
Most of the ProcError enum varients now carry an optional path
component, which indicates the path that we were operating on when the
IO error happened.  Also, this error type now implements the Error trait
from the stdlib.

Closes prometheus#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants