Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UIDs to ProcStatus struct #243

Merged
merged 1 commit into from
Dec 8, 2019
Merged

Add UIDs to ProcStatus struct #243

merged 1 commit into from
Dec 8, 2019

Conversation

keitwb
Copy link

@keitwb keitwb commented Dec 2, 2019

These are left as a string since the built-in function os.LookupId
accepts UID as a string.

These are left as a string since the built-in function os.LookupId
accepts UID as a string.

Signed-off-by: Ben Keith <bkeith@signalfx.com>
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keitwb
Copy link
Author

keitwb commented Dec 6, 2019

@mdlayher Does this seem alright to you?

@discordianfish discordianfish merged commit 42f6e29 into prometheus:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants