Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loadavg #251

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Add support for loadavg #251

merged 1 commit into from
Jan 23, 2020

Conversation

tukeJonny
Copy link
Contributor

@tukeJonny tukeJonny commented Dec 20, 2019 •
edited

Signed-off-by: tukeJonny ne250143@yahoo.co.jp.

This is my first contribution to this project.
This PR adds support for parsing /proc/loadavg.

fixes #239

@tukeJonny tukeJonny force-pushed the add-support-loadavg branch 2 times, most recently from e2052a8 to 854b378 Compare December 23, 2019 01:16
@tukeJonny
Copy link
Contributor Author

@mdlayher
Could you review this PR when you're free? 🙇

pgier
pgier reviewed Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@pgier pgier left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just have a minor suggestion inline.
Also, would you mind squashing the commits and create a single commit log message?

loadavg.go Outdated Show resolved Hide resolved
@tukeJonny tukeJonny force-pushed the add-support-loadavg branch 2 times, most recently from 8480e88 to d4e06f5 Compare January 21, 2020 23:23
@tukeJonny
Copy link
Contributor Author

tukeJonny commented Jan 21, 2020 •
edited

@pgier
Thanks for the feedback!
I fix up parseLoad, And squash commits (Exactly, there are extra commits... Thanks for your advice!).

Please re-review this PR 🙇

pgier
pgier reviewed Jan 22, 2020
View reviewed changes
loadavg.go Outdated Show resolved Hide resolved
@tukeJonny
Add support for /proc/loadavg
4b6750a 
Signed-off-by: tukeJonny <ne250143@yahoo.co.jp>
pgier
pgier approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgier pgier merged commit 871b9bb into prometheus:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgier pgier pgier approved these changes

@discordianfish discordianfish discordianfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement parsing of /proc/loadavg
3 participants
@tukeJonny @pgier @discordianfish