Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for CPUInfo for ARM on Linux kernels 3.8+ #296

Merged
merged 1 commit into from
May 21, 2020
Merged

Added support for CPUInfo for ARM on Linux kernels 3.8+ #296

merged 1 commit into from
May 21, 2020

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented May 18, 2020

Fixes issue #294

Hi @bluecmd, please have a look and let me know if you think I should do any changes on the PR. Thanks!

bluecmd
bluecmd suggested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@bluecmd bluecmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

cpuinfo.go Outdated Show resolved Hide resolved
cpuinfo.go Show resolved Hide resolved
@kadern0
Added support for CPUInfo for ARM on Linux kernels 3.8+
12d4418 
Fixes issue prometheus#294

Signed-off-by: kadern0 <kaderno@gmail.com>
@kadern0
Copy link
Contributor Author

kadern0 commented May 19, 2020

@bluecmd I think it is ready for a second round :)

bluecmd
bluecmd approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@bluecmd bluecmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! I'm not a maintainer however, so you need to track one down for their review.

pgier
pgier approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks very much for working on this!

discordianfish
discordianfish approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@discordianfish discordianfish merged commit b101fad into prometheus:master May 21, 2020
@kolyshkin kolyshkin mentioned this pull request May 21, 2020
Draft
@pgier pgier mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecmd bluecmd bluecmd approved these changes

@pgier pgier pgier approved these changes

@discordianfish discordianfish discordianfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kadern0 @bluecmd @pgier @discordianfish