Custom build tag "nostatfs" disables statfs #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to specify the "nostatfs" build tag to disable this feature if needed. In our case, we are using Tamago (https://github.com/usbarmory/tamago), which does not support syscall.Statfs. Without this change attempting to build returns 'undefined: syscall.Statfs' and 'undefined: syscall.Statfs_t'. With this change, we can build successfully build our tamago executables provided that "nostatfs" is added to the build tags. This option seems preferable to adding "tamago" as a build tag here, and will scale to other use cases too. Signed-off-by: Martin Hutchinson <mhutchinson@gmail.com>
mhutchinson
force-pushed
the
tamagoNoStatfs
branch
from
3549fc5
to
180cd44
Compare
mhutchinson
added a commit
to mhutchinson/armored-witness-applet
that referenced
this pull request
Jul 26, 2023
This is blocked on prometheus/procfs#553 being merged and released.
|
Thanks for the quick review @SuperQ! So I can manage expectations, when is this likely to be merged and a release available? |
mhutchinson
added a commit
to mhutchinson/armored-witness-applet
that referenced
this pull request
Jul 26, 2023
This is blocked on prometheus/procfs#553 being merged and released.
|
Release v0.11.1 tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to specify the "nostatfs" build tag to disable this feature if needed.
In our case, we are using Tamago (https://github.com/usbarmory/tamago), which does not support syscall.Statfs. Without this change attempting to build returns 'undefined: syscall.Statfs' and 'undefined: syscall.Statfs_t'. With this change, we can build successfully build our tamago executables provided that "nostatfs" is added to the build tags.
This option seems preferable to adding "tamago" as a build tag here, and will scale to other use cases too.