Skip to content

Commit

Permalink
scrape_test.go: Increase scrape interval in TestScrapeLoopCache to re…
Browse files Browse the repository at this point in the history
…duce potential flakiness

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
  • Loading branch information
machine424 committed Dec 27, 2023
1 parent 0763ec8 commit 2f60177
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scrape/scrape_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1194,7 +1194,9 @@ func TestScrapeLoopCache(t *testing.T) {
)

ctx, cancel := context.WithCancel(context.Background())
sl := newBasicScrapeLoop(t, ctx, scraper, app, 10*time.Millisecond)
// Decreasing the scrape interval could make the test fail, as multiple scrapes might be initiated at identical millisecond timestamps.
// See https://github.com/prometheus/prometheus/issues/12727.
sl := newBasicScrapeLoop(t, ctx, scraper, app, 100*time.Millisecond)

numScrapes := 0

Expand Down

0 comments on commit 2f60177

Please sign in to comment.