Merge pull request #13831 from prometheus/cherry-pick-13803

Release 2.51: Cherry-pick #13803 bugfix for label_join
prometheus · Mar 26, 2024 · d771cab · d771cab
2 parents c05c155 + 17e2c30
commit d771cab
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/promql/functions.go b/promql/functions.go
@@ -1386,6 +1386,9 @@ func (ev *evaluator) evalLabelJoin(args parser.Expressions) (parser.Value, annot
 		}
 		srcLabels[i-3] = src
 	}
+	if !model.LabelName(dst).IsValid() {
+		panic(fmt.Errorf("invalid destination label name in label_join(): %s", dst))
+	}
 
 	val, ws := ev.eval(args[0])
 	matrix := val.(Matrix)