Fix race condition when updating lastSeriesID during loading chunk sn…

…apshot Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
prometheus · Aug 3, 2022 · f7b46a3 · f7b46a3
1 parent a23e950
commit f7b46a3
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tsdb/head_wal.go b/tsdb/head_wal.go
@@ -921,8 +921,12 @@ func (h *Head) loadChunkSnapshot() (int, int, map[chunks.HeadSeriesRef]*memSerie
 					return
 				}
 				localRefSeries[csr.ref] = series
-				if chunks.HeadSeriesRef(h.lastSeriesID.Load()) < series.ref {
-					h.lastSeriesID.Store(uint64(series.ref))
+				for {
+					seriesID := uint64(series.ref)
+					lastSeriesID := h.lastSeriesID.Load()
+					if lastSeriesID >= seriesID || h.lastSeriesID.CAS(lastSeriesID, seriesID) {
+						break
+					}
 				}
 
 				series.chunkRange = csr.chunkRange