Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nhcb: write basic unit tests for custom histograms and implement #13531

Open
Tracked by #13485
krajorama opened this issue Feb 2, 2024 · 2 comments
Open
Tracked by #13485

nhcb: write basic unit tests for custom histograms and implement #13531

krajorama opened this issue Feb 2, 2024 · 2 comments
Assignees

Comments

@krajorama
Copy link
Member

Proposal

Depends on #13508

Add unit tests for histogram_avg, histogram_count, histogram_sum,.. functions on custom histograms
Add unit tests for operations on custom histograms that share the same bucket layout. Addition, average, max, min, etc.

@miledxz
Copy link
Contributor

miledxz commented Feb 7, 2024

Heey @krajorama, feel free to assign me on this one,
would be good to add required tests

@krajorama
Copy link
Member Author

@zedGGs thank you for the offer. FYI, there's a bunch of dependencies to be able to start testing this for real, follow the links in the description. If you still feel like starting, please target the https://github.com/prometheus/prometheus/tree/nhcb branch with PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Assigned
Development

No branches or pull requests

2 participants