Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBoundaryValues() and GetRangeValues() should return labels in SampleSets #26

Closed
juliusv opened this issue Jan 8, 2013 · 3 comments
Closed
Assignees

Comments

@juliusv
Copy link
Member

juliusv commented Jan 8, 2013

I've only tested GetRangeValues() so far, but maybe GetBoundaryValues() has the same behavior. The SampleSets that get returned have a nil-map as the Metric member, whereas they should probably contain the labels that the function was called with, to yield a proper timeseries.

It's not a big problem right now, because the caller has the right labels anyways and can insert them. However, I'm not sure if that's intended.

@ghost ghost assigned matttproud Jan 8, 2013
@matttproud
Copy link
Member

@juliusv, is this still relevant?

@juliusv
Copy link
Member Author

juliusv commented Mar 28, 2013

The view and storage methods now only take fingerprints, so while some of them still do metric lookups for those, I don't want to require them to do that anymore (and don't need it). Right now I get the fingerprints myself in the view adapter and this is fine. Closing this.

@juliusv juliusv closed this as completed Mar 28, 2013
matttproud added a commit that referenced this issue Apr 9, 2014
Add formal fingerprint sets for intersection ops.
simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017
Add FAQ section on stability guarantees.
@lock
Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants