Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add SD implementation backed by a gRPC interface for custom providers #6484

Closed
yskopets opened this issue Dec 18, 2019 · 5 comments

Comments

@yskopets
Copy link

Proposal

  • In the context of a Service Mesh, there is always a notion of a Control Plane that coordinates telemetry among other things
  • It would be perfect for overall user experience if a Control Plane could also become a source of scrape targets (specifically, for collecting metrics out of side-car proxies)
  • As a way to achieve that, we would like to propose to introduce a gRPC interface for SD that Control Planes could implement
  • The choice of gRPC will enable effective server-side streaming of SD information, and it will remove the requirement on users to think upfront about refresh intervals they cannot choose reliably anyway
  • There is already a well-defined, battle-tested and widely used protocol for delivering discovery information - Envoy xDS API
  • Based on all the above, we would like to ask if Prometheus community is open for such a contribution
@roidelapluie
Copy link
Member

roidelapluie commented Dec 18, 2019

Hi,

Thank you for your interest in Prometheus.

From our docs:

It should not be a brand new SD mechanism, or a variant of an established mechanism. We want to integrate Prometheus with the SD that's already there in your infrastructure, not invent yet more ways to do service discovery.

Plus, what can't you achieve with the Kubernetes service discovery? I guess what you describe is probably doable with the current kubernetes discovery.

Such a discussion would be better on the Prometheus-dev mailing list.

@roidelapluie
Copy link
Member

I propose to move this to the prometheus-dev mailing list.

@yskopets
Copy link
Author

Service Mesh is not limited to Kubernetes.

We want to bring the same out-of-the-box experience to Service Meshes running on VMs and in hybrid environments.

@yskopets
Copy link
Author

yskopets commented Dec 18, 2019

I created an identical post on #prometheus-dev

@bboreham
Copy link
Member

bboreham commented Apr 2, 2024

No movement in 5 years; we have http SD; let's close this.

@bboreham bboreham closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants