Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fileutil.Readdir with ioutil.ReadDir everywhere (in TSDB?) #7029

Closed
codesome opened this issue Mar 22, 2020 · 0 comments · Fixed by #7033
Closed

Replace fileutil.Readdir with ioutil.ReadDir everywhere (in TSDB?) #7029

codesome opened this issue Mar 22, 2020 · 0 comments · Fixed by #7033
Labels
help wanted low hanging fruit

Comments

@codesome
Copy link
Member

I have separated a small part of #6979 into it's own issue as the rest of the stuff is fixed there.

Quoting from there: We're also using ioutil.ReadDir in one place and our own fileutil.Readdir on top of Readdirnames in another, we should unify this on ioutil.Readdir rather than inventing our own thing.
@codesome codesome mentioned this issue Mar 22, 2020
Closed
@ghost ghost mentioned this issue Mar 23, 2020
Merged
codesome pushed a commit that referenced this issue Apr 6, 2020
Replace fileutil.ReadDir with ioutil.ReadDir (#7029) (#7033)
3348930 
* tsdb: Replace fileutil.ReadDir with ioutil.ReadDir (#7029)

Signed-off-by: Brad Walker <brad@bradmwalker.com>

* tsdb: Remove fileutil.ReadDir (#7029)

Signed-off-by: Brad Walker <brad@bradmwalker.com>
@gotjosh gotjosh mentioned this issue Apr 28, 2020
Closed
4 tasks
@prometheus prometheus locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify io.ReadDir usage (#7029)
1 participant
@codesome